Skip to content

fix(carbon): fix time picker minute range #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

GilbertCherrie
Copy link
Contributor

Description

Changed minute overflow calculation to occur at 60 minutes instead of 59.

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #1150 (ae78ad7) into master (afb4d83) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1150   +/-   ##
=======================================
  Coverage   94.89%   94.89%           
=======================================
  Files         209      209           
  Lines        3567     3567           
  Branches     1234     1234           
=======================================
  Hits         3385     3385           
  Misses        182      182           
Impacted Files Coverage Δ
...nt-mapper/src/time-picker-date/time-picker-date.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f18bb2b...ae78ad7. Read the comment docs.

@DataDrivenFormsBot
Copy link

A new version (fix) will be released: v3.15.2 [DataDrivenFormsBot]

@rvsia rvsia added bug Something isn't working Carbon PRs/Issues for IBM's Carbon design system labels Oct 18, 2021
@rvsia rvsia merged commit 23784c0 into data-driven-forms:master Oct 18, 2021
@GilbertCherrie
Copy link
Contributor Author

@Hyperkid123 Is there any chance this PR can be backported to version 2 of DDF. Only asking because we need this for older versions of ManageIQ currently using DDF version 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Carbon PRs/Issues for IBM's Carbon design system released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants