-
Notifications
You must be signed in to change notification settings - Fork 91
fix(pf4): Field-Array no longer shows delete all when minItems has a … #1149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(pf4): Field-Array no longer shows delete all when minItems has a … #1149
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, change title/description/commit message from maxItems
to mintItems
😅
A new version (fix) will be released: v3.15.1 [DataDrivenFormsBot] |
Lint error: home/circleci/react-forms/packages/pf4-component-mapper/src/field-array/field-array.js
104:51 error Replace `onClick:·()·=>·removeBatch(value.map((_,·index)·=>·index))` with `·onClick:·()·=>·removeBatch(value.map((_,·index)·=>·index))·` prettier/prettier |
…value greater than 0
720e8c8
to
8107659
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Codecov Report
@@ Coverage Diff @@
## master #1149 +/- ##
=======================================
Coverage 94.90% 94.90%
=======================================
Files 208 208
Lines 3531 3533 +2
Branches 1213 1215 +2
=======================================
+ Hits 3351 3353 +2
Misses 180 180
Continue to review full report at Codecov.
|
🎉 This PR is included in version 3.15.1 🎉 The release is available on |
Fixes #(issue) (if applicable)
I did not create an issue for this but it is in relation to the discussions for PR #1146
Description
When
maxItems
has a value greater than 0 we should not show thedeleteAll
button.Please include a summary of the change.
When
maxItems
is greater than 0 it will no longer show theDelete all
button. This prevents the component from incidentally wiping the contents of the field-array whenmaxItems
is set.Schema (if applicable)
Checklist: (please see documentation page for more information)
Yarn build
passesYarn lint
passesYarn test
passes