Skip to content

Choice of conjugation in complex inner product #616

Closed
@lezcano

Description

@lezcano

vecdot is defined for complex vectors as $\langle x, y \rangle = \sum_i x_i \overline{y_i}$. This can be written as $\langle x, y \rangle = y^H x$ (note how the order of the parameters is swapped).

In PyTorch we define it as $\langle x, y \rangle = x^H y$. This notation is more common in physics, while the previous notation is more common in complex geometry. For a short discussion see this wikipedia page.

I would argue that numerical libraries are more targeted to physics people than to pure math people, so perhaps it'd be better to stick with the physics notation?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions