Use ndindex.iter_indices in _test_stacks in the linalg tests - #86
Merged
Conversation
This adds ndindex >= 1.6 as a dependency of the test suite.
We will eventually change this to be a float-point approximate check rather than exact equality. For now, this is not updated. See data-apis#44
Member
Author
|
This should be ready to go. I'll make my further changes in another PR so that we can do a release now. |
Member
|
LGTM. Great to see a |
Member
Author
|
Yeah. Sorry it took so long. Let me know if you run across any other complex indexing related things that you think ndindex could help with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds ndindex >= 1.6 as a dependency of the test suite.
I'm also going to try to make the tests pass.
I want to update some of the existing tests to use this as well, but I am going to do that in a second PR because it shouldn't block a release.