Repository navigation
Like-for-like replacement of KeyedLock with AsyncKeyedLock library. - #21
Conversation
elsand
left a comment
There was a problem hiding this comment.
Thanks for this, the library looks good and we would like to integrate this. However, we cannot delete the current KeyedLock implementation from Dan.Common, as this namespace is deployed as a nuget and removing it will require a major version bump. Please re-add KeyedLock.cs, and I will merge this.
|
I've re-implemented KeyedLock using AsyncKeyedLocker internally. I'm not sure if you want to add an [Obsolete] to KeyedLock. |
|
Oops sorry about that @elsand, realized I hadn't actually hit the save button on the changes I did, you can see them now. Once more, I'm not sure if you want to add an [Obsolete] to KeyedLock. |
Very nice, thanks :)
Yes, that's a good idea. |
OK, done. Over to you to merge. |
Made a like-for-like replacement of the KeyedLock with a more performant AsyncKeyedLock library. You may want to review the pool size or remove it altogether, but I left it with the value of 10 to be just like KeyedLock was.