Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Wire protocol (DEP) #8

Merged
merged 23 commits into from
Feb 27, 2019
Merged

Draft: Wire protocol (DEP) #8

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
a152756
skeleton of wire protocol DEP
bnewbold Feb 5, 2018
7960439
Add "Block Tree Digest" to 000-wire-protocol
pfrazee Feb 6, 2018
22db0da
Remove manual line-wrapping (sorry bryan)
pfrazee Mar 4, 2018
c820c76
More work on 000-wire-protocol.md
pfrazee Mar 4, 2018
4fc1641
Fix typo
pfrazee Mar 4, 2018
a3e0f18
Typo fix in proposals/0000-wire-protocol.md
pfrazee Jun 1, 2018
d1118ab
address some review feedback
bnewbold Nov 18, 2018
0867356
more wire protocol review feedback
bnewbold Nov 18, 2018
6f9d026
wire protocol references section
bnewbold Nov 18, 2018
e9e383d
Buffer.alloc in example code
bnewbold Nov 18, 2018
3a303cb
early wire protocol history/changelog
bnewbold Nov 18, 2018
e761143
privacy/security section for wire protocol
bnewbold Nov 18, 2018
db2bd39
wire protocol typos
bnewbold Jan 20, 2019
740b893
clarify discovery key generation (keyed hash)
bnewbold Jan 20, 2019
c4e394a
clarify stream encoding a bit (from review)
bnewbold Jan 20, 2019
e872f91
clarify that tracking is shown for HTTP, not Dat
bnewbold Jan 20, 2019
f17d15e
clarify ack flag
bnewbold Jan 20, 2019
2df9b33
re-write block digest section
bnewbold Jan 20, 2019
1cff4fe
switch block digest example again (to 6)
bnewbold Jan 20, 2019
bcbc902
switch to pseudo-code (not javascript)
bnewbold Jan 20, 2019
9e753b2
all protobuf ints are varint
bnewbold Jan 20, 2019
cb3c3a8
first submitted 2019-01-19
bnewbold Feb 13, 2019
03a1f1d
updates from review
bnewbold Feb 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clarify ack flag 
Thanks @emilbayes.

See also: holepunchto/hypercore#130
  • Loading branch information
@bnewbold
bnewbold committed Jan 20, 2019
commit f17d15ea63529221a2c7c76f23bf3d9fbaddff0c
2 changes: 1 addition & 1 deletion proposals/0000-wire-protocol.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,7 @@ Some notes on the fields:
- **live** If both peers set to true, the connection will be kept open indefinitely.
- **userData** An open field for sending data which you can retrieve on handshake. No value is prescribed by the protocol.
- **extentions** A list of strings identifying additional message-types which are supported via the Extension message.
- **ack** Should all blocks be explicitly acknowledged? TODO how should this work?
- **ack** A peer (the "sender") can set this flag to request that every time another peer (a "receiver") gets a `Data` message from the sender, that they reply with an explicit `Have` message once they have successfully persisted the data in storage. This lets the "sender" track how many persisted copies of a chunk there are.

```
message Handshake {
Expand Down