Clarify DNS TXT record schema modification #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As requested in dat-ecosystem-archive#62 (comment) , clarified that DNS TXT record datkey match can be anywhere in the TXT record.
RangerMauve
reviewed
Sep 2, 2019
| @@ -59,12 +59,14 @@ Users have multiple options for creating a domain-name mapping. | |||
| ## DNS TXT record | |||
| [usage-dns-txt-record]: #usage-dns-txt-record | |||
|
|
|||
| The first option is to set a DNS TXT record at the domain which maps to a "key"-addressed Dat URL. The client will lookup this TXT record first and load the resulting Dat. That record should fit the following schema: | |||
| The first option is to set a DNS TXT record at the domain which maps to a "key"-addressed Dat URL. The client will lookup this TXT record first and load the resulting Dat. That record should contain the following schema: | |||
|
|
|||
| ``` | |||
| datkey={key} | |||
There was a problem hiding this comment.
Could we clarify that the key in this case must be 64 hex characters?
There was a problem hiding this comment.
Ok I have added that to the note. on line 68.
As requested by @RangerMauve
RangerMauve
approved these changes
Sep 3, 2019
There was a problem hiding this comment.
LGTM. Thanks for the PR! 💜 We'll wait for another core dev to confirm before we merge. cc @pfrazee
|
Sorry for the delay, had a conference. PR looks great. Thank you @ryanramage ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #62 (comment) , clarified that DNS TXT record datkey match can be anywhere in the TXT record.