Truncate large coro repr in retry log output#9197
Open
ernestprovo23 wants to merge 1 commit intodask:mainfrom
Open
Truncate large coro repr in retry log output#9197ernestprovo23 wants to merge 1 commit intodask:mainfrom
ernestprovo23 wants to merge 1 commit intodask:mainfrom
Conversation
When retry() falls back to str(coro) for the log message, truncate the representation to 200 characters to prevent excessively large logs. This was observed in P2P shuffles where functools.partial repr includes serialized binary data. Closes dask#8529
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 31 files ± 0 31 suites ±0 11h 16m 57s ⏱️ + 9m 23s For more details on these failures, see this check. Results for commit 30ddcdc. ± Comparison against base commit 4fb4814. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
retry()falls back tostr(coro)for log messages, truncate the representation to 200 characters to prevent excessively large logsfunctools.partialrepr includes serialized binary data (see Fix excessive logging on P2P retry #8511)Closes #8529
Test plan
test_retry_truncates_large_coro_reprverifies 500-char repr is truncatedoperationparameter bypasses truncation (preserves full user-provided descriptions)🤖 Generated with Claude Code