-
-
Notifications
You must be signed in to change notification settings - Fork 750
Add generic type support to Future and Client methods #9123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ±0 27 suites ±0 9h 35m 56s ⏱️ - 7m 17s For more details on these failures, see this check. Results for commit 81fe1e2. ± Comparison against base commit c9e7aca. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately mypy isn't happy with this. Could you take a look at the failing linter job and ensure mypy is passing. You might want to run pre-commit install to check this locally before pushing commits to GitHub.
|
I now made sure the pre-commit hooks pass. |
|
Docs build failures will be fixed by #9125 |
|
You can if you like. It doesn't matter too much, I just wanted to point out that the docs build failure is unrelated to this PR. |
|
Ok. Apart from that: is there something left that I need to do before it can get merged? |
jacobtomlinson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If mypy is happy then I'm happy 😆
|
Thanks for merging! |
Closes #9099
pre-commit run --all-files