Skip hanging SSH tests on Windows #9115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ± 0 27 suites ±0 8h 51m 18s ⏱️ + 1h 34m 10s For more details on these failures, see this check. Results for commit 52e258f. ± Comparison against base commit d548dae. ♻️ This comment has been updated with latest results. |
Member
Author
|
Skipping one test just seems to hang on the next test |
jacobtomlinson
changed the title
Member
|
+1 for skipping on win32 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9114
Old SSH tests are hanging on Windows. Given that these tests are for a deprecated API I think we are safe to just skip on Windows. We should probably consider removing this old API at some point too.
pre-commit run --all-files