Update persist in tests for async clients #9089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An earlier PR (lost the link, sorry) changed how `persist` works in our tests with async clients. Instead of calling `collection.persist()` you instead use `client.persist`. Applying that change to some of the GPU-marked tests.
TomAugspurger
added a commit
to TomAugspurger/dask-upstream-testing
that referenced
this pull request
Jun 9, 2025
We added these skips when I wasn't sure why these tests were failing. The presence of these skips caused CI failures in the upstream repos when we bumped things: - rapidsai/dask-cuda#1487 - rapidsai/ucxx#418 Lesson: skips are OK, though still not desired, for tests in dask / distributed. Skips for downstream rapids failures are not OK. Merge once dask/distributed#9089 is in distributed. Closes rapidsai#53
This was referenced Jun 9, 2025
jrbourbeau
approved these changes
Jun 9, 2025
Member
jrbourbeau
left a comment
jrbourbeau
left a comment
There was a problem hiding this comment.
Thanks @TomAugspurger. LGTM overall -- one (non-blocking) comment
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ±0 27 suites ±0 11h 18m 53s ⏱️ + 9m 12s For more details on these failures, see this check. Results for commit 5e79fb1. ± Comparison against base commit ca6efac. ♻️ This comment has been updated with latest results. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An earlier PR (lost the link, sorry) changed how
persistworks in our tests with async clients. Instead of callingcollection.persist()you instead useclient.persist. Applying that change to some of the GPU-marked tests.