Fix test_resubmit_nondeterministic_task_different_deps
#9085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAugspurger
approved these changes
Jun 2, 2025
Member
TomAugspurger
left a comment
TomAugspurger
left a comment
There was a problem hiding this comment.
At a glance, this looks like a fine improvement. My limited understanding is that Future._state is set after the Future is created, and so callers of Future.status and type should be expected to handle the case where they aren't set yet.
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ±0 27 suites ±0 11h 9m 23s ⏱️ - 21m 0s For more details on these failures, see this check. Results for commit 3ad943c. ± Comparison against base commit 801d0ed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this should fix
test_resubmit_nondeterministic_task_different_deps(it does for me locally). I'll admit that I don't fully understand what change in dask/dask#11945 is causing this test to fail...Currently
Future._stateisn't being set, but our code expects it to be, so the change here might actually just be mask over something (why_stateisn't being set in the first place) instead of fixing the underlying issuecc @jacobtomlinson @TomAugspurger for vis and thoughts (if you happen have any here)
Closes #9080