Fix workers / threads / memory displayed in client repr #9066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobtomlinson
approved these changes
May 2, 2025
Member
jacobtomlinson
left a comment
jacobtomlinson
left a comment
There was a problem hiding this comment.
Looks good thanks @jrbourbeau
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ±0 27 suites ±0 10h 21m 38s ⏱️ + 4m 55s For more details on these failures and errors, see this check. Results for commit 7036713. ± Comparison against base commit f56b02e. |
Member
Author
|
Noting that test failures here are unrelated (xref #9060) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client repr is currently getting the number of workers, threads, and memory from
client.scheduler_info()["workers"]. However in #9045 we truncated the number of workers included inscheduler_info()by default (which didn't scale well).Luckily we're tracking the info displayed in the client repr separately from
scheduler_info()["workers"](e.g.scheduler_info()["total_threads"]. This PR updates the repr to not rely on the"workers"info (also updates a test accordingly).Closes #9065