Skip to content

Return a default value if address resolution fails #9051

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacobtomlinson merged 1 commit into from
Apr 22, 2025
Merged

Return a default value if address resolution fails #9051

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions distributed/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,10 +171,23 @@ def get_fileno_limit():
@toolz.memoize
def _get_ip(host, port, family):
def hostname_fallback():
addr_info = socket.getaddrinfo(
socket.gethostname(), port, family, socket.SOCK_DGRAM, socket.IPPROTO_UDP
)[0]
return addr_info[4][0]
try:
addr_info = socket.getaddrinfo(
socket.gethostname(),
port,
family,
socket.SOCK_DGRAM,
socket.IPPROTO_UDP,
)[0]
return addr_info[4][0]
# If getaddrinfo() fails, relay the error and return a sane default
except socket.gaierror as e:
warnings.warn(
f"Couldn't detect a suitable IP address ({e}). "
"Falling back to 127.0.0.1.",
RuntimeWarning,
)
return "127.0.0.1"

# By using a UDP socket, we don't actually try to connect but
# simply select the local address through which *host* is reachable.
Expand Down
Loading