Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homogeneously schedule P2P's unpack tasks #8873

Merged
merged 4 commits into from
Sep 13, 2024

Conversation

hendrikmakait
Copy link
Member

@hendrikmakait hendrikmakait commented Sep 13, 2024

Before this PR, P2P would schedule all unpack tasks on a single worker. For large-scale shuffles/rechunks, this caused the workload to stall and the scheduler to become severely CPU-pressured.

p2p-scheduling
  • Tests added / passed
  • Passes pre-commit run --all-files

@hendrikmakait hendrikmakait mentioned this pull request Sep 13, 2024
4 tasks
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    25 files  ± 0      25 suites  ±0   10h 19m 35s ⏱️ + 6m 28s
 4 124 tests  -  1   4 007 ✅  -  3    111 💤 ±0  6 ❌ +2 
47 640 runs   - 11  45 529 ✅  - 13  2 105 💤 ±0  6 ❌ +2 

For more details on these failures, see this check.

Results for commit 1c0a178. ± Comparison against base commit ec3f4ec.

This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both.
distributed.shuffle.tests.test_shuffle ‑ test_unpack_is_non_rootish
distributed.tests.test_scheduler ‑ test_override_is_rootish
distributed.shuffle.tests.test_rechunk ‑ test_homogeneously_schedule_unpack

Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I'm looking forward to taking this for a spin later today

@hendrikmakait
Copy link
Member Author

A/B testing shows no impact (which isn't surprising given that we don't run a good test for this particular case)
Screenshot 2024-09-13 at 19 43 37

(https://github.com/coiled/benchmarks/actions/runs/10851966565)

@jrbourbeau jrbourbeau merged commit 4f3ac26 into dask:main Sep 13, 2024
24 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants