Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace all occurrences of sys.is_finalizing #8449

Merged
merged 6 commits into from
Jan 15, 2024

Conversation

fjetter
Copy link
Member

@fjetter fjetter commented Jan 11, 2024

We stumbled again over some noisiness during interpreter shutdown inside of the Futures __del__. For this we implemented the is_python_shutting_down utility which has slightly different semantics than the actual python sys.is_finalizing. I have to admit that I don't fully understand the differences but from what I can tell our toggle is set a little bit earlier. Reviewing all of our usage of sys.is_finalizing I think it is safe to use the utility everywhere for simplicity.

Copy link
Contributor

github-actions bot commented Jan 11, 2024

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

    27 files  ±  0      27 suites  ±0   10h 7m 0s ⏱️ + 26m 16s
 3 960 tests +  8   3 850 ✅ +  9    109 💤 ±0  1 ❌  - 1 
49 809 runs  +118  47 518 ✅ +126  2 290 💤  - 7  1 ❌  - 1 

For more details on these failures, see this check.

Results for commit a41ec76. ± Comparison against base commit d93d498.

♻️ This comment has been updated with latest results.

@hendrikmakait
Copy link
Member

It looks like test_quiet_close_process isn't happy with these changes.

@hendrikmakait hendrikmakait self-requested a review January 11, 2024 14:48
@fjetter
Copy link
Member Author

fjetter commented Jan 12, 2024

if tests keep failing, let's just change the one in Future and keep it at that. No point in wasting our time hunting this down

@hendrikmakait
Copy link
Member

if tests keep failing, let's just change the one in Future and keep it at that. No point in wasting our time hunting this down

Looks like I'm playing ping-pong with test failures. I'll reactivate my PR.

@hendrikmakait
Copy link
Member

Looks like I'm playing ping-pong with test failures. I'll reactivate my PR.

I may have figured it out.

@hendrikmakait hendrikmakait changed the title Replace all ocurences of sys.is_finalizing Replace all occurrences of sys.is_finalizing Jan 12, 2024
@fjetter fjetter merged commit ba34f53 into dask:main Jan 15, 2024
30 of 34 checks passed
@fjetter fjetter deleted the use_is_python_shutting_down_client branch January 15, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants