-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace all occurrences of sys.is_finalizing #8449
Replace all occurrences of sys.is_finalizing #8449
Conversation
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 27 files ± 0 27 suites ±0 10h 7m 0s ⏱️ + 26m 16s For more details on these failures, see this check. Results for commit a41ec76. ± Comparison against base commit d93d498. ♻️ This comment has been updated with latest results. |
It looks like |
if tests keep failing, let's just change the one in |
Looks like I'm playing ping-pong with test failures. I'll reactivate my PR. |
I may have figured it out. |
We stumbled again over some noisiness during interpreter shutdown inside of the Futures
__del__
. For this we implemented theis_python_shutting_down
utility which has slightly different semantics than the actual pythonsys.is_finalizing
. I have to admit that I don't fully understand the differences but from what I can tell our toggle is set a little bit earlier. Reviewing all of our usage ofsys.is_finalizing
I think it is safe to use the utility everywhere for simplicity.