WIP Test unclosed comms #8058
WIP Test unclosed comms #8058
Conversation
| pool = await ConnectionPool() | ||
| try: | ||
| await pool(server.address).ping() | ||
| finally: | ||
| await pool.close() |
There was a problem hiding this comment.
FWIW this also triggers with a plain rpc so it's likely not the pool
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 20 files ± 0 20 suites ±0 11h 58m 31s ⏱️ + 39m 49s For more details on these failures, see this check. Results for commit c51912d. ± Comparison against base commit 9a9d2c3. |
|
This test is a false positive. I am getting unclosed comms at the end of the test because I still have tasks with a connectionpool running. Those tasks have a running pool with an already established connection but haven't processed the closing server, yet. they will close properly and cleanup everything. This suggests that the leak happens somewhere further up the stack. possibly a Server.close is not properly awaiting the pool close or we're leaking a comm somewhere else |
I think this is (kind of) minimally reproducing #8054