Skip to content

Add spans to Fine Performance Metrics bokeh dashboard #7911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2023
Merged

Add spans to Fine Performance Metrics bokeh dashboard #7911

merged 1 commit into from
Jun 15, 2023

Conversation

@crusaderky
Copy link
Collaborator

@crusaderky crusaderky commented Jun 14, 2023 •
edited
Loading

@crusaderky crusaderky requested a review from fjetter as a code owner June 14, 2023 14:26
@crusaderky crusaderky mentioned this pull request Jun 14, 2023
Merged
@crusaderky crusaderky self-assigned this Jun 14, 2023
@crusaderky crusaderky requested a review from milesgranger June 14, 2023 14:27
@crusaderky crusaderky mentioned this pull request Jun 14, 2023
Open
@github-actions
Copy link
Contributor

github-actions bot commented Jun 14, 2023

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       20 files  ±    0         20 suites  ±0   12h 29m 57s ⏱️ + 1h 2m 9s
  3 679 tests ±    0    3 571 ✔️ +    5     106 💤  -   2  2 ❌  - 3 
35 763 runs  +183  34 082 ✔️ +271  1 679 💤  - 85  2 ❌  - 3 

For more details on these failures, see this check.

Results for commit 22613f6. ± Comparison against base commit 74a1bcd.

This pull request removes 2 and adds 2 tests. Note that renamed tests count towards both. 
distributed.protocol.tests.test_numpy
distributed.shuffle.tests.test_rechunk

distributed.tests.test_spans ‑ test_merge_by_tags
distributed.tests.test_spans ‑ test_merge_by_tags_metrics

@crusaderky crusaderky mentioned this pull request Jun 15, 2023
Merged
@crusaderky crusaderky merged commit 50aedd7 into dask:main Jun 15, 2023
@crusaderky crusaderky deleted the spans_bokeh branch June 15, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fjetter fjetter Awaiting requested review from fjetter fjetter is a code owner

1 more reviewer

@milesgranger milesgranger milesgranger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@crusaderky crusaderky

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crusaderky @milesgranger