Refactor Scheduler.is_idle #7881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 20 files ± 0 20 suites ±0 11h 12m 24s ⏱️ - 36m 17s For more details on these failures, see this check. Results for commit 669429d. ± Comparison against base commit 57639c1. |
milesgranger
approved these changes
Jun 5, 2023
Comment on lines
+2666
to
+2667
| """TaskGroup.done is True iff all of its tasks are in memory, erred, released, or | ||
| forgotten state |
There was a problem hiding this comment.
Suggested change
| """TaskGroup.done is True iff all of its tasks are in memory, erred, released, or | |
| forgotten state | |
| """TaskGroup.done is True if all of its tasks are in memory, erred, released, or | |
| forgotten state |
There was a problem hiding this comment.
iff = if and only if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #7790
Move non-trivial logic of
Scheduler.is_idleto the task groups. This is a propaedeutic step to reuse the same logic in spans (#7860).Fix a regression introduced in 2023.5.1, where a cluster with erred tasks would not be considered idle, thus causing unrelated Computations to be merged into one, until the failed task is forgotten (cc @ntabris)