Log exceptions in P2P shuffle tasks #7442
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Unit Test ResultsSee test report for an extended history of previous test failures. This is useful for diagnosing flaky tests. 22 files ± 0 22 suites ±0 9h 28m 14s ⏱️ - 1m 47s For more details on these failures, see this check. Results for commit 6e57cd3. ± Comparison against base commit b5a2078. ♻️ This comment has been updated with latest results. |
fjetter
reviewed
Jan 4, 2023
Comment on lines
51
to
54
| except Exception: | ||
| raise RuntimeError(f"shuffle_transfer failed during shuffle {id}") | ||
| msg = f"shuffle_transfer failed during shuffle {id}" | ||
| logger.error(msg, exc_info=True) | ||
| raise RuntimeError(msg) |
Member
There was a problem hiding this comment.
you should get the proper traceback with
Suggested change
| except Exception: | |
| raise RuntimeError(f"shuffle_transfer failed during shuffle {id}") | |
| msg = f"shuffle_transfer failed during shuffle {id}" | |
| logger.error(msg, exc_info=True) | |
| raise RuntimeError(msg) | |
| except Exception as exc: | |
| raise RuntimeError(msg) from exc |
Member
Author
There was a problem hiding this comment.
Exception chaining sometimes threw a recursion error back in #7326 which is why we dropped it.
fjetter
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs the traceback of the caught exception for better observability. Previously, traceback information had been lost.
pre-commit run --all-files