Skip to content

Note queuing default change in changelog #7314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 16, 2022

Conversation

gjoseph92
Copy link
Collaborator

This is a rather major change, so good to highlight, especially if anyone needs to switch the setting back.

@gjoseph92 gjoseph92 requested a review from jrbourbeau November 16, 2022 00:30
@github-actions
Copy link
Contributor

Unit Test Results

See test report for an extended history of previous test failures. This is useful for diagnosing flaky tests.

       15 files  ±0         15 suites  ±0   6h 43m 1s ⏱️ + 10m 47s
  3 219 tests ±0    3 132 ✔️  - 2    84 💤 +1  3 +1 
23 803 runs  ±0  22 890 ✔️  - 2  910 💤 +1  3 +1 

For more details on these failures, see this check.

Results for commit bb31ca9. ± Comparison against base commit 176a84c.

@crusaderky crusaderky merged commit 5635bc0 into dask:main Nov 16, 2022
Copy link
Member

@jrbourbeau jrbourbeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for including this @gjoseph92. I'll try to do a better job including notes like this in the future -- also please feel free to ping me on a PR if you think it merits a note in the changelog.

Thoughts on cross posting https://www.coiled.io/blog/reducing-dask-memory-usage in the Dask blog (with a disclaimer that it was originally written for the Coiled blog)? cc @jacobtomlinson

@gjoseph92 gjoseph92 deleted the changelog-queuing branch November 16, 2022 17:15
@gjoseph92
Copy link
Collaborator Author

No worries, I didn't think of it until after you'd made the release.

Certainly in favor of cross-posting!

@jrbourbeau
Copy link
Member

Cool -- me too. Mind opening up a PR over in the Dask blog repo? Should be mostly copy-and-paste

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants