-
-
Notifications
You must be signed in to change notification settings - Fork 734
Withhold root tasks [no co assignment] #6614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
fjetter
merged 104 commits into
dask:main
from
gjoseph92:withold-root-tasks-no-co-assign
Aug 31, 2022
Merged
Changes from all commits
Commits
Show all changes
104 commits
Select commit
Hold shift + click to select a range
afedccd
unused: `OrderedSet` collection
gjoseph92 6b6651b
Queue root tasks scheduler-side
gjoseph92 6225d1a
Show queued tasks with crosshatching on dashboard
gjoseph92 1496abb
improve reasonableness of task-state order
gjoseph92 7457865
Allow configurable oversaturation
gjoseph92 67e9bd2
Only support floats for `worker-oversaturation`
gjoseph92 2410a82
Push memory limits a little more in test
gjoseph92 49d5ddd
Queued tasks on info pages
gjoseph92 b546997
driveby: WIP color task graph by worker
gjoseph92 2b44820
Revert "driveby: WIP color task graph by worker"
gjoseph92 e494e87
Queued tasks on graph
gjoseph92 ad417ed
Redistribute queues when new worker joins
gjoseph92 b4c698e
Fix task_slots_available when queuing disabled
gjoseph92 aa4e531
Fix co-assignment logic to consider queued tasks
gjoseph92 b514e84
Revert "unused: `OrderedSet` collection"
gjoseph92 1835a89
Fix potential stale worker use in decide_worker
gjoseph92 db42c22
WIP identify root task families
gjoseph92 0f6603c
Withhold root tasks [no co-assignment]
gjoseph92 e10fdca
Factor out `_add_to_processing`
gjoseph92 3eb1d68
Factor out `_propagage_released`
gjoseph92 c685b3c
Update `check_idle_saturated`
gjoseph92 e1dda98
Fix `topk` for 0/negative values
gjoseph92 f811246
Tests for HeapSet.topk
gjoseph92 d347b32
fix mypy
gjoseph92 1990dd7
worker-oversaturation -> worker-saturation
gjoseph92 be1b9ca
fixup! Factor out `_add_to_processing`
gjoseph92 85f9120
fix `test_queued_tasks_rebalance`
gjoseph92 bb08c8d
Fix occupancy tests
gjoseph92 966d61f
Test releasing previously queued paused tasks
gjoseph92 15494f0
driveby: fix transition debug log end state
gjoseph92 546aa4a
Refactor scheduling when no workers are running
gjoseph92 ffbb53b
Don't send queued tasks to no-worker
gjoseph92 65735f8
Schedule rootish tasks when some workers are paused
gjoseph92 6bf710c
Rever less-intrusive all-paused handling
gjoseph92 25e6f3b
Decrease test_root_task_overproduction size
gjoseph92 988b0cf
Merge remote-tracking branch 'upstream/main' into withold-root-tasks-…
gjoseph92 b86fe0f
Co-assignment when queuing is disabled
gjoseph92 7ebd1d9
Fix co-assignment for binary operations
gjoseph92 034f980
Turn withholding off by default
gjoseph92 0af53b4
Merge remote-tracking branch 'upstream/main' into withold-root-tasks-…
gjoseph92 a63d25b
Remove redundant insert into `idle`
gjoseph92 5f7e7f1
Update `idle` docstring
gjoseph92 9aeecc9
fix `test_ready_remove_worker`
gjoseph92 dcb11e4
fix `test_saturation_factor`
gjoseph92 7dfc83e
remove debug dashboards from tests
gjoseph92 c99bbe8
fix `progress_stream`
gjoseph92 c1544f3
fix `test_prometheus_collect_task_states`
gjoseph92 349712f
fix config json schema
gjoseph92 594585e
fix retire workers
gjoseph92 b4f843d
update `validate_task_state`
gjoseph92 2db4db9
fix `test_saturation_factor` again
gjoseph92 8395ef4
ignore long-running in `task_slots_available`
gjoseph92 36a60a5
hackily consider queue in adaptive target
gjoseph92 da04438
update explanation in schema slightly
gjoseph92 c92236c
update comments in `decide_worker`
gjoseph92 e990b92
formalize `transition_queued_processing` assertion
gjoseph92 0d21c78
correct bulk_schedule comment
gjoseph92 b40cec1
private `_task_slots_available`
gjoseph92 12b94d0
`worker_saturated` -> `_worker_full`
gjoseph92 4c0e768
remove unused `_add_to_processing` return value
gjoseph92 14cc157
yaml schema fixes
gjoseph92 f5d7be4
`topk` -> `peekn`
gjoseph92 704b485
driveby: fix `saturated` docstring
gjoseph92 38e0598
driveby: clarify `finish2` name
gjoseph92 d47e80d
Split up `decide_worker`, remove recs
gjoseph92 2cc8631
remove no_worker->memory just to see what happens
gjoseph92 100118a
Render scheduler state graph with inline graphviz
gjoseph92 842ee71
Update scheduling state graph and docs slightly
gjoseph92 494fe48
Merge remote-tracking branch 'upstream/main' into withold-root-tasks-…
gjoseph92 dd88b0d
apt package is graphviz, not dot
gjoseph92 e17c624
Revert "remove no_worker->memory just to see what happens"
gjoseph92 06d60fe
Revert "Render scheduler state graph with inline graphviz"
gjoseph92 96d59eb
Update scheduling state docs
gjoseph92 3240a43
`test_root_task_overproduction` adaptive data size
gjoseph92 9344dd9
Don't assert rootish in `decide_worker`
gjoseph92 aa8e1db
improve `test_queued_paused`
gjoseph92 ee1a754
`test_queued_paused_unpaused`
gjoseph92 f36a6ac
`bulk_schedule_after_adding_worker` docstring
gjoseph92 78353e1
`test_queued_remove_add_worker`
gjoseph92 18b7bb5
reorder and quicken `test_queued_tasks_rebalance`
gjoseph92 f3a66df
queued tasks cause scale-up from empty
gjoseph92 c5f2746
Improve adaptive target for queued tasks
gjoseph92 4b2a209
don't need that fail_func
gjoseph92 3cebe54
remove `test_oversaturation_multiple_task_groups`
gjoseph92 51dca31
Merge remote-tracking branch 'upstream/main' into withold-root-tasks-…
gjoseph92 14dc850
Documentation suggestions
gjoseph92 b36064e
`test_graph_execution_width`
gjoseph92 5b2bc02
skip `test_root_task_overproduction` on windows
gjoseph92 1819a51
Merge remote-tracking branch 'upstream/main' into withold-root-tasks-…
gjoseph92 2952f6b
few more type annotations since they're available
gjoseph92 d00ea54
`decide_worker_rootish_queuing_enabled` no task
gjoseph92 8ba4ced
fix `check_idle` for queued tasks
gjoseph92 63d863d
_remove_from_processing->_exit_processing_common
gjoseph92 b7704e3
remove `test_queued_tasks_rebalance`
gjoseph92 00b54e7
`scheduler.allowed-failures` instead of PIDs
gjoseph92 12207e6
test_root_task_overproduction->test_near_memory_limit_workload
gjoseph92 02c98b3
remove all sleeps from `graph_execution_width`
gjoseph92 2b3f6ae
remove `test_near_memory_limit_workload`
gjoseph92 5e4d53d
`handle_worker_status_change` in `retire_workers`
gjoseph92 333bbb2
Merge remote-tracking branch 'upstream/main' into withold-root-tasks-…
gjoseph92 acc524f
avoid flaky `test_graph_execution_width`
gjoseph92 ba336b9
fix test_decide_worker_coschedule_order_binary_op
gjoseph92 9d99d74
fixup! `handle_worker_status_change`
gjoseph92 093d7dc
Fix merge conflict of renaming transfer log
fjetter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.