Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion distributed/scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -3354,13 +3354,18 @@ def del_scheduler_file():
setproctitle(f"dask-scheduler [{self.address}]")
return self

async def close(self):
async def close(self, fast=None, close_workers=None):
"""Send cleanup signal to all coroutines then wait until finished

See Also
--------
Scheduler.cleanup
"""
if fast is not None or close_workers is not None:
warnings.warn(
"The 'fast' and 'close_workers' parameters in Scheduler.close have no effect and will be removed in a future version of distributed.",
FutureWarning,
)
if self.status in (Status.closing, Status.closed):
await self.finished()
return
Expand Down
6 changes: 6 additions & 0 deletions distributed/tests/test_scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -3595,3 +3595,9 @@ async def test_worker_state_unique_regardless_of_address(s, w):
assert ws1 is not ws2
assert ws1 != ws2
assert hash(ws1) != ws2


@gen_cluster(nthreads=[("", 1)])
async def test_scheduler_close_fast_deprecated(s, w):
with pytest.warns(FutureWarning):
await s.close(fast=True)