port test_local.LocalTest to pytest tests to allow use of loop fixture #6523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
commented
Jun 7, 2022
| self.client.close() | ||
| self.cluster.close() | ||
|
|
||
| @pytest.mark.xfail() |
There was a problem hiding this comment.
this test failed because self.Cluster(2, made a LocalCluster(name=2, n_workers=nprocesses_nthreads()
6 tasks
fjetter
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #6163
the LocalTest tests are based on ClusterTest and unittest.TestCase, these tests are outdated as they assume the first argument of the passed in
Clusterisn_workers- however this is nowname, and by being based on unittest they didn't allow convenient use of fixtures