AMM: speed up and stabilize test_memory #5737
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crusaderky
force-pushed
the
AMM/test_memory
branch
2 times, most recently
from
43e939b to
dcb4961
Compare
2 tasks
crusaderky
force-pushed
the
AMM/test_memory
branch
from
dcb4961 to
03a936a
Compare
Collaborator
Author
|
All test failures are unrelated. |
gjoseph92
reviewed
Jan 31, 2022
Collaborator
gjoseph92
left a comment
gjoseph92
left a comment
There was a problem hiding this comment.
If this indeed reduces flakiness, LTGM.
distributed/tests/test_scheduler.py
Outdated
| initial_timeout = 40 | ||
| else: | ||
| initial_timeout = 0 | ||
| # Trigger potential imports inside WorkerPlugin events |
Collaborator
There was a problem hiding this comment.
inside WorkerPlugin events
What do you mean by this?
Collaborator
Author
There was a problem hiding this comment.
>>> class MyPlugin(WorkerPlugin):
... def transition(self, key, start, finish, *args, **kwargs):
... import heavy_dependency
Co-authored-by: Gabe Joseph <gjoseph92@gmail.com>
crusaderky
commented
Feb 1, 2022
Co-authored-by: Gabe Joseph <gjoseph92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_memory becomes heavily flaky after #5695. This PR makes it pass before and after #5695.