Skip to content

Set port 8786 as default port for scheduler #4431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Set port 8786 as default port for scheduler #4431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7cc78f5
use port 8687 as default port for scheduler
FabioRosado Jan 15, 2021
88f8e14
add tiny test
FabioRosado Jan 15, 2021
bf16cc2
Update test following James suggestion
FabioRosado Jan 15, 2021
a488a95
Fix typo on method name
FabioRosado Jan 15, 2021
695d33f
Pass schedule_port explicitly on tests
FabioRosado Jan 15, 2021
9a89392
Revert changes to tests
FabioRosado Jan 23, 2021
0b1a666
Use port 0 for inproc and 8786 for other protocols
FabioRosado Jan 23, 2021
9f5e8a5
Merge branch 'master' into default-ports
FabioRosado Jan 23, 2021
05f039e
Set default port for tcp connection only
FabioRosado Jan 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion distributed/deploy/local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def __init__(
start=None,
host=None,
ip=None,
scheduler_port=0,
scheduler_port=None,
silence_logs=logging.WARN,
dashboard_address=":8787",
worker_dashboard_address=None,
Expand Down Expand Up @@ -169,6 +169,11 @@ def __init__(
if not protocol.endswith("://"):
protocol = protocol + "://"

if protocol.startswith("tcp"):
scheduler_port = 8786
else:
scheduler_port = 0

if host is None and not protocol.startswith("inproc") and not interface:
host = "127.0.0.1"

Expand Down
9 changes: 9 additions & 0 deletions distributed/deploy/tests/test_local.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@

from dask.system import CPU_COUNT
from distributed import Client, Worker, Nanny, get_client
from distributed.comm.addressing import parse_host_port
from distributed.core import Status
from distributed.deploy.local import LocalCluster
from distributed.metrics import time
Expand Down Expand Up @@ -1049,6 +1050,14 @@ async def test_no_workers(cleanup):
pass


@pytest.mark.asyncio
async def test_default_scheduler_port():
async with LocalCluster(n_workers=2, processes=False, asynchronous=True) as cluster:

_, port = parse_host_port(cluster.scheduler_address)
assert port == 8786


@pytest.mark.asyncio
async def test_cluster_names():
async with LocalCluster(processes=False, asynchronous=True) as unnamed_cluster:
Expand Down