Skip to content

Turn off bokeh property validation in dashboard - #2387

Merged
mrocklin merged 2 commits into
dask:masterfrom
jcrist:bokeh-no-validation
Nov 30, 2018
Merged

mrocklin merged 2 commits into
dask:masterfrom
jcrist:bokeh-no-validation

Conversation

@jcrist

@jcrist jcrist commented Nov 30, 2018

Copy link
Copy Markdown
Member

Bokeh 1.0.0 added a method to turn off property validation contextually, improving performance. Here we make use that method to remove validation in the dashboard update methods. For older versions of bokeh this PR is a no-op.

Fixes #2342.

Bokeh 1.0.0 added a method to turn off property validation contextually,
improving performance. Here we make use that method to remove validation
in the dashboard update methods. For older versions of bokeh this PR is
a no-op.
@mrocklin

Copy link
Copy Markdown
Member

Looks good. Thanks @jcrist !

@mrocklin
mrocklin merged commit 22c6f17 into dask:master Nov 30, 2018
@jcrist
jcrist deleted the bokeh-no-validation branch November 30, 2018 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants