Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated LoopRunner API #7239

Open
fjetter opened this issue Nov 2, 2022 · 1 comment
Open

Remove deprecated LoopRunner API #7239

fjetter opened this issue Nov 2, 2022 · 1 comment
Labels
asyncio deprecation Something is being removed

Comments

@fjetter
Copy link
Member

fjetter commented Nov 2, 2022

We deprecated functionality around LoopRunner that allowed to pass closed/not-running loops to it, see #6680

It's been ~3 months now and we should remove the deprecated functionality. This also relates to tornado 6.2 and py3.11 compat, see #7134

Closes #6163

@wence- you started looking into this. Are you still interested?

cc @graingert
@fjetter fjetter added deprecation Something is being removed asyncio labels Nov 2, 2022
@wence-
Copy link
Contributor

wence- commented Nov 2, 2022

@wence- you started looking into this. Are you still interested?

Yes. I got some way in but then because quite confused about whose responsibility it should be to start the event loop. Removing the final make_current in Nanny._run wasn't sufficient to remove usage of deprecated asyncio functionality AFAICT.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
asyncio deprecation Something is being removed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wence- @fjetter