Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename network-related settings in config #6977

Open
crusaderky opened this issue Aug 30, 2022 · 1 comment
Open

Rename network-related settings in config #6977

crusaderky opened this issue Aug 30, 2022 · 1 comment
Labels
config hygiene Improve code quality and reduce maintenance overhead

Comments

@crusaderky
Copy link
Collaborator

crusaderky commented Aug 30, 2022

Follow-up to #6933

This is very ugly and confusing:

transfer_incoming_count_limit = dask.config.get(
"distributed.worker.connections.outgoing"
)
self.transfer_outgoing_count_limit = dask.config.get(
"distributed.worker.connections.incoming"
)

We should rename

  • distributed.worker.connections.outgoing to distributed.worker.transfer.incoming_count_limit
  • distributed.worker.connections.incoming to distributed.worker.transfer.outgoing_count_limit

The renames must be added to distributed.config.aliases.

CC @hendrikmakait

@crusaderky crusaderky added hygiene Improve code quality and reduce maintenance overhead config labels Aug 30, 2022
@crusaderky
Copy link
Collaborator Author

The aliases are non-trivial because they are not yet supported in dask/dask:
https://github.com/dask/dask/blob/222ea067db35f65787ee2a877b6e29bb85ae9eed/dask/config.py#L557-L558

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config hygiene Improve code quality and reduce maintenance overhead
Projects
None yet
Development

No branches or pull requests

1 participant