flaky `test_local_directory_make_new_directory`

[hendrikmakait]

___________________ test_local_directory_make_new_directory ___________________

s = <Scheduler 'tcp://127.0.0.1:56579', workers: 0, cores: 0, tasks: 0>

    @gen_cluster(nthreads=[])
    async def test_local_directory_make_new_directory(s):
        with tmpfile() as fn:
            w = await Worker(s.address, local_directory=os.path.join(fn, "foo", "bar"))
>           assert w.local_directory.startswith(fn)
E           AssertionError: assert False
E            +  where False = <built-in method startswith of str object at 0x000002864E7F21F0>('C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpm5w8krsm.')
E            +    where <built-in method startswith of str object at 0x000002864E7F21F0> = 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpm5w8krsm\\foo\\bar\\dask-worker-space\\worker-ft9gojr9'.startswith
E            +      where 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpm5w8krsm\\foo\\bar\\dask-worker-space\\worker-ft9gojr9' = <Worker 'tcp://127.0.0.1:56580', status: running, stored: 0, running: 0/2, ready: 0, comm: 0, waiting: 0>.local_directory

distributed\tests\test_worker.py:1381: AssertionError
---------------------------- Captured stdout call -----------------------------
Dumped cluster state to test_cluster_dump\test_local_directory_make_new_directory.yaml
---------------------------- Captured stderr call -----------------------------
2022-08-23 07:32:50,924 - distributed.diskutils - ERROR - Failed to remove 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpm5w8krsm\\foo\\bar\\dask-worker-space\\worker-ft9gojr9' (failed in <built-in function scandir>): [WinError 3] The system cannot find the path specified: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpm5w8krsm\\foo\\bar\\dask-worker-space\\worker-ft9gojr9'
2022-08-23 07:32:50,924 - distributed.diskutils - ERROR - Failed to remove 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpm5w8krsm\\foo\\bar\\dask-worker-space\\worker-ft9gojr9' (failed in <built-in function rmdir>): [WinError 2] The system cannot find the file specified: 'C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpm5w8krsm\\foo\\bar\\dask-worker-space\\worker-ft9gojr9'

https://github.com/dask/distributed/runs/7967444014?check_suite_focus=true#step:11:1288

See also: #6934

Notes:

• So far, this has only appeared on windows-latest, 3.10.

[gjoseph92]

It seems pretty likely that a specific recent change caused these:

[fjetter]

There are actually no changes between the two runs. Both the last successful and the first failure run on b7e184a

I suggest to compare software environments, maybe a transitive dependency changed

[fjetter]

Looking at the strings, it's interesting that fn=C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmpm5w8krsm. the period at the end appears to be the offender that makes the "startswith" check fail