Skip to content

distributed.utils_test.popen does not use binaries from PATH #5069

@jacobtomlinson

Description

@jacobtomlinson

While debugging some dask-mpi issue I noticed that tests fail if openmpi is installed with apt rather than conda. xref dask/dask-mpi#71 (comment)

This seems to be because distributed.utils_test.popen assumes all binaries will be within the sys.prefix which in this case is not true.

os.environ.get("DESTDIR", "") + sys.prefix, "bin", args[0]

I would assume that popen(["foo", ...]... would call the same binary that which foo displays.

It seems this was done in #1954 but there's isn't much context as to why this was done. @mrocklin could you shed any light on this?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions