Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mild type annotations #2803

Closed
mrocklin opened this issue Jun 25, 2019 · 1 comment · Fixed by #5348
Closed

Add mild type annotations #2803

mrocklin opened this issue Jun 25, 2019 · 1 comment · Fixed by #5348

Comments

@mrocklin
Copy link
Member

We should investigate adding mild type annotations to this project. By this I mean simple types like str and int that aren't contentious, and nothing complex.

We might then investigate the value of adding mypy to CI.

I think that this would be a good first step before adding typing annotations to the core dask project. I think that it makes sense to start here because:

  1. We're more tied to Python 3 due to the async-await syntax
  2. We're slightly less core
@jrbourbeau
Copy link
Member

It's been a while since this issue was originally opened and since then some type annotations have made there way into the distributed code base. If we're going to have type annotations (which I think there's interest in) then we should consider adding a mypy check in our CI to make sure they are correct (maybe in our existing pre-commit check?)

@crusaderky you and I have talked about this a few times offline. IIRC you mentioned, since mypy will effectively ignore non-annotated functions, adding an initial mypy check may be relatively straightforward. If that's the case, is this something you're interested in taking on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants