Code review; fix regressions

dask · Sep 27, 2021 · 5802463 · 5802463
1 parent a2678bd
commit 5802463
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/distributed/diagnostics/tests/test_scheduler_plugin.py b/distributed/diagnostics/tests/test_scheduler_plugin.py
@@ -140,7 +140,7 @@ async def close(self):
     plugin = LifeCycle()
     async with Scheduler(dashboard_address=":0") as s:
         s.add_plugin(plugin)
-        pass
+        await plugin.start(s)
 
     assert plugin.history == ["started", "closed"]
     assert plugin.scheduler is s

diff --git a/distributed/worker.py b/distributed/worker.py
@@ -2585,7 +2585,7 @@ async def gather_dep(
                         ("busy-gather", worker, to_gather_keys, stimulus_id, time())
                     )
 
-                recommendations = {}
+                recommendations: dict[TaskState, str | tuple] = {}
                 deps_to_iter = self.in_flight_workers.pop(worker)
 
                 for d in deps_to_iter:

diff --git a/setup.py b/setup.py
@@ -43,8 +43,8 @@
     except ImportError:
         setup_requires.append("cython")
 
-    _, _, params = cython_arg.partition("=")
-    params = params.split(",")
+    _, _, params_str = cython_arg.partition("=")
+    params = params_str.split(",")
     profile = "profile" in params
     if "annotate" in params:
         import Cython.Compiler.Options