-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP Switch to the PyData Theme #87
Draft
jacobtomlinson
wants to merge
7
commits into
dask:main
Choose a base branch
from
jacobtomlinson:pydata-theme
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ooh, fun! |
Ok things are building now so we can look at the preview at https://dask-sphinx-theme--87.org.readthedocs.build/en/87/. I'm going to start tinkering with CSS next. |
Excited to follow along here, thanks @jacobtomlinson! |
@jacobtomlinson any progress on CSS? I'm excited to see how nice we can make this look. |
Sorry I haven't had a chance to come back here yet. I will though! |
I believe in you Jacob!
…On Thu, May 9, 2024 at 4:58 AM Jacob Tomlinson ***@***.***> wrote:
Sorry I haven't had a chance to come back here yet. I will though!
—
Reply to this email directly, view it on GitHub
<#87 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACKZTGIUL5T7S7TYN2ZDZTZBNCEHAVCNFSM6AAAAABGSZ5N4WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBSGM2DGOJTGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mrocklin, @scharlottej13 and I have been chatting recently about giving the documentation a bit of a refresh.
This theme is currently pinned to an old version of the Sphinx Book Theme which prevents us from upgrading our Sphinx version. Upgrading to a new version would likely require a large overhaul of the CSS and custom theming in this repo, so we thought we would try out a different base theme which aligned more with the design goals we have in mind.
This PR replaces the base theme and updates the custom styling to make the PyData theme look more like Dask.