Skip to content

Skip Job cluster creation if already exists #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

Skip Job cluster creation if already exists #941

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3bc8db6
Skip Job cluster creation if already exists
jacobtomlinson Apr 16, 2025
b22360f
Bump pre-commit action
jacobtomlinson Apr 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@ jobs:
python-version: "3.10"
- name: Install deps
run: ./ci/install-deps.sh
- uses: pre-commit/action@v2.0.0
- uses: pre-commit/action@v3.0.1
12 changes: 7 additions & 5 deletions dask_kubernetes/operator/controller/controller.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -781,10 +781,11 @@ async def daskjob_create_components(
)
kopf.adopt(cluster_spec)
cluster = await DaskCluster(cluster_spec, namespace=namespace)
await cluster.create()
logger.info(
f"Cluster {cluster_spec['metadata']['name']} for job {name} created in {namespace}."
)
if not await cluster.exists():
await cluster.create()
logger.info(
f"Cluster {cluster_spec['metadata']['name']} for job {name} created in {namespace}."
)

labels = _get_labels(meta)
annotations = _get_annotations(meta)
Expand All @@ -804,7 +805,8 @@ async def daskjob_create_components(
)
kopf.adopt(job_pod_spec)
job_pod = await Pod(job_pod_spec, namespace=namespace)
await job_pod.create()
if not await job_pod.exists():
await job_pod.create()
patch.status["clusterName"] = cluster_name
patch.status["jobStatus"] = "ClusterCreated"
patch.status["jobRunnerPodName"] = get_job_runner_pod_name(name)
Expand Down
Loading