Skip to content

Pin dask-gateway version for tests on older Kubernetes versions #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Pin dask-gateway version for tests on older Kubernetes versions #939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dask_kubernetes/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,10 @@
import uuid
from typing import Final, Iterator

import kr8s
import pytest
from kopf.testing import KopfRunner
from packaging.version import Version
from pytest_kind.cluster import KindCluster

DIR: Final[pathlib.Path] = pathlib.Path(__file__).parent.absolute()
Expand Down Expand Up @@ -105,6 +107,7 @@ def namespace(k8s_cluster: KindCluster) -> Iterator[str]:

@pytest.fixture(scope="session", autouse=True)
def install_gateway(k8s_cluster: KindCluster) -> Iterator[None]:
kube_version = Version(kr8s.version().get("gitVersion"))
if bool(os.environ.get("TEST_DASK_GATEWAY", False)):
check_dependency("helm")
# To ensure the operator can coexist with Gateway
Expand All @@ -115,6 +118,8 @@ def install_gateway(k8s_cluster: KindCluster) -> Iterator[None]:
"dask-gateway",
"dask-gateway",
"--install",
"--version",
"2024.1.0" if kube_version < Version("1.30.0") else ">=2024.1.0",
"--repo=https://helm.dask.org",
"--create-namespace",
"--namespace",
Expand Down
Loading