Change project to account where appropriate. Update docs#586
Merged
Conversation
guillaumeeb
commented
Sep 5, 2022
| warn = ( | ||
| "header_skip has been renamed to job_directives_skip. " | ||
| "You are still using it (even if only set to (); please also check config files). " | ||
| "You are still using it (even if only set to []; please also check config files). " |
Member
Author
There was a problem hiding this comment.
This is an unrelated fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #272.
Currently dask-jobqueue uses incorrect terms and kwarg name for Accounting string. PBS and Slurm implementations are declaring an accounting string, but the kwarg was named
project. This PR renames the kwarg toaccount, as project should be use with-PPBS or Slurm option.It also fixes wrong comment about
projectkwarg for other job schedulers.