Breakout common changes in fourier_gaussian #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In all cases `sigma` is squared, the result is divided by `2`, and the negative of the result taken. These can be factored out into a common change to just `sigma` that is reused in all of the other computations. Admittedly Dask is smart enough to capture the reused computation of `sigma` squared, but it is not a symbolic algebra library. So it won't be able to pick up on the other changes, but we can. This should simplify the resulting graph and make it easy to reuse some common changes to `sigma` before `tensordot` is computed over multiple arrays and these changes applied.
|
Should add that if On a more general note, as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all cases
sigmais squared, the result is divided by2, and the negative of the result taken. These can be factored out into a common change to justsigmathat is reused in all of the other computations. Admittedly Dask is smart enough to capture the reused computation ofsigmasquared, but it is not a symbolic algebra library. So it won't be able to pick up on the other changes, but we can. This should simplify the resulting graph and make it easy to reuse some common changes tosigmabeforetensordotis computed over multiple arrays and these changes applied.