-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO MRG] Retest gpuCI #317
Conversation
rerun tests |
Thanks Charles! 🙏 Is there typically a lag between when a CI fix is merged and when other PRs can get the fix? |
Yeah, currently the images are made on a nightly basis, so any changes to the environment files would only be reflected once the next scheduled run is complete; in this case, I manually triggered a rebuild of the images so that we could more immediately test the change. Perhaps a good compromise between minimizing runtime and reflecting changes to the environment files would be to run |
Ah ok. Thanks for the context (and the assist)! 🙏 That seems reasonable. Would that go after this step or somewhere else? dask-image/continuous_integration/gpuci/build.sh Lines 36 to 38 in c62a503
|
Thank you @charlesbluca and @jakirkham for tying to figure this out! |
I don't think it should matter, but I suppose updating before activating the environment wouldn't hurt - I can open up a PR trying this out to see if there's any immediately obvious issues we would run into EDIT: Opened #318 which seems to work well, if that seems like a sensible solution to the lag between environment updates being reflected on the GPU CI side happy to try this out for the other Dask projects where this has also occasionally been an issue |
Toggling to retest with PR ( #318 ) merged |
Seems like things are working now as PR ( #309 ) also passed Closing this out Thanks again Charles! 🙏 |
Opening this PR to test gpuCI now that PR ( #315 ) has been merged
cc @GenevieveBuckley @charlesbluca