Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO MRG] Retest gpuCI #317

Closed
wants to merge 1 commit into from
Closed

[NO MRG] Retest gpuCI #317

wants to merge 1 commit into from

Conversation

jakirkham
Copy link
Member

Opening this PR to test gpuCI now that PR ( #315 ) has been merged

cc @GenevieveBuckley @charlesbluca

@jakirkham jakirkham changed the title Trivial newline change for CI [NO MRG] Retest gpuCI May 10, 2023
@charlesbluca
Copy link
Member

rerun tests

@jakirkham
Copy link
Member Author

Thanks Charles! 🙏

Is there typically a lag between when a CI fix is merged and when other PRs can get the fix?

@charlesbluca
Copy link
Member

Yeah, currently the images are made on a nightly basis, so any changes to the environment files would only be reflected once the next scheduled run is complete; in this case, I manually triggered a rebuild of the images so that we could more immediately test the change.

Perhaps a good compromise between minimizing runtime and reflecting changes to the environment files would be to run mamba update -f $ENV at the beginning of each run?

@jakirkham
Copy link
Member Author

Ah ok. Thanks for the context (and the assist)! 🙏

That seems reasonable. Would that go after this step or somewhere else?

gpuci_logger "Activate conda env"
. /opt/conda/etc/profile.d/conda.sh
conda activate dask_image

@GenevieveBuckley
Copy link
Collaborator

Thank you @charlesbluca and @jakirkham for tying to figure this out!

@charlesbluca
Copy link
Member

charlesbluca commented May 15, 2023

Would that go after this step or somewhere else?

I don't think it should matter, but I suppose updating before activating the environment wouldn't hurt - I can open up a PR trying this out to see if there's any immediately obvious issues we would run into

EDIT:

Opened #318 which seems to work well, if that seems like a sensible solution to the lag between environment updates being reflected on the GPU CI side happy to try this out for the other Dask projects where this has also occasionally been an issue

@jakirkham jakirkham closed this May 17, 2023
@jakirkham jakirkham reopened this May 17, 2023
@jakirkham
Copy link
Member Author

Toggling to retest with PR ( #318 ) merged

@jakirkham
Copy link
Member Author

Seems like things are working now as PR ( #309 ) also passed

Closing this out

Thanks again Charles! 🙏

@jakirkham jakirkham closed this May 17, 2023
@jakirkham jakirkham deleted the tst_gpuci branch May 17, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants