-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add alias to gaussian_filter #193
Conversation
Here are some comments, although you might like to wait a bit for responses to this comment before trying it out.
dask-image/dask_image/ndmeasure/__init__.py Lines 716 to 719 in 91fe6e1
Obviously, there's no need for a warning in this PR. Maybe the docstring could be as simple as
|
@GenevieveBuckley Thanks a lot for your comments! It seems like there is no objection(s) in the comment, so I'd given it another try. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @K-Monty, I've added some comments for you.
The checks all seem to have passed with your most recent commit, so I wouldn't worry about why they failed earlier unless we start seeing that again.
Ok, this looks good to me now! I'm going to leave this PR open for another week, just to give @jakirkham & others a bit more time for this discussion around design decisions. If there are no strong objections in a week, then we'll merge this here (feel free to ping me if I forget). |
Closes #192
Before you submit a pull request, check that it meets these guidelines:
your new functionality into a function with a docstring, and add the
feature to the list in README.rst.
https://travis-ci.org/dask/dask-image/pull_requests
and make sure that the tests pass for all supported Python versions.