-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINTENANCE: rename sum to sum_labels and add a deprecation warning #123 #172
Conversation
Co-authored-by: Genevieve Buckley <30920819+GenevieveBuckley@users.noreply.github.com>
Thanks. It WFM. I will also add |
Ok, now we need a def sum(image, label_image=None, index=None):
"""Docstring goes here"""
warnings.warn("Deprecation message goes here", DeprecationWarning)
return sum_labels(image, label_image=label_image, index=index) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Excellent work @tkoyama010
@GenevieveBuckley Thanks for great help ☺ |
MAINTENANCE: rename sum to sum_labels and add a deprecation warning #123
Join the big image sprint at SciPy Japan 2020 (#163)