Update to JLab 3 #217
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| {"data":{"layout-restorer:data":{"main":{"dock":{"type":"split-area","orientation":"horizontal","sizes":[0.5,0.5],"children":[{"type":"tab-area","currentIndex":0,"widgets":["markdownviewer-widget:Welcome.md"]},{"type":"split-area","orientation":"vertical","sizes":[0.5,0.5],"children":[{"type":"tab-area","currentIndex":0,"widgets":["dask-dashboard-launcher:/individual-task-stream"]},{"type":"tab-area","currentIndex":0,"widgets":["dask-dashboard-launcher:/individual-progress"]}]}]},"current":"markdownviewer-widget:Welcome.md"},"down":{"size":0,"widgets":[]},"left":{"collapsed":false,"current":"filebrowser","widgets":["filebrowser","jp-property-inspector","running-sessions","dask-dashboard-launcher","@jupyterlab/toc:plugin","extensionmanager.main-view"]},"right":{"collapsed":true,"widgets":["debugger-sidebar"]},"relativeSizes":[0.16362230919765167,0.8363776908023483,0]},"file-browser-filebrowser:cwd":{"path":""},"workspace-ui:lastSave":"/default.jupyterlab-workspace","markdownviewer-widget:Welcome.md":{"data":{"path":"Welcome.md","factory":"Markdown Preview"}},"dask-dashboard-launcher:/individual-task-stream":{"data":{"route":"/individual-task-stream","label":"Task Stream","key":"Task Stream"}},"dask-dashboard-launcher:/individual-progress":{"data":{"route":"/individual-progress","label":"Progress","key":"Progress"}},"dask-dashboard-launcher":{"url":"DASK_DASHBOARD_URL","cluster":""}},"metadata":{"id":"default","last_modified":"2021-12-20T20:41:35.169956+00:00","created":"2021-12-20T20:41:35.169956+00:00"}} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,9 +1,13 @@ | ||||||
| #!/bin/bash | ||||||
|
|
||||||
| # Replace DASK_DASHBOARD_URL with the proxy location | ||||||
| sed -i -e "s|DASK_DASHBOARD_URL|${JUPYTERHUB_BASE_URL}user/${JUPYTERHUB_USER}/proxy/8787|g" binder/example.jupyterlab-workspace | ||||||
|
|
||||||
| # TODO: Importing of workspace via CLI is currently broken. | ||||||
| # remove this workaround once https://github.com/jupyterlab/jupyterlab/issues/10805 is resolved | ||||||
| mkdir -p ~/.jupyter/lab/workspaces/ | ||||||
| mv binder/example.jupyterlab-workspace ~/.jupyter/lab/workspaces/default-37a8.jupyterlab-workspace | ||||||
|
There was a problem hiding this comment. The
Suggested change
There was a problem hiding this comment. This is 100% a hack -- that's a hash based on the workspace name which is not guaranteed to be stable. But I think it might be okay for the time-being, and is better than the currently broken state. There was a problem hiding this comment. Gotcha -- totally fine with me if it works |
||||||
| # Import the workspace | ||||||
| # jupyter lab workspaces import binder/example.jupyterlab-workspace | ||||||
|
|
||||||
| exec "$@" | ||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduces some conflicts with #218, so this should be merged first then I can fix that one.