Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Robert Pająk <pellared@hotmail.com>
  • Loading branch information
dashpole and pellared authored Oct 9, 2023
1 parent a515ff9 commit dffefdf
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions bridge/opencensus/metric.go
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ import (
"go.opentelemetry.io/otel/sdk/metric/metricdata"
)

// MetricProducer implements the metric.Producer interface to provide metrics
// MetricProducer implements the [go.opentelemetry.io/otel/sdk/metric.Producer] to provide metrics
// from OpenCensus to the OpenTelemetry SDK.
type MetricProducer struct {
manager *metricproducer.Manager
Expand All @@ -42,8 +42,8 @@ func NewMetricProducer(opts ...MetricOption) *MetricProducer {

var _ metric.Producer = (*MetricProducer)(nil)

// Produce implements metric.Producer by fetching metrics from the OpenCensus
// manager, translating them to OpenTelemetry's data model, and returning them.
// Produce fetches metrics from the OpenCensus manager,
// translates them to OpenTelemetry's data model, and returns them.
func (p *MetricProducer) Produce(context.Context) ([]metricdata.ScopeMetrics, error) {
producers := p.manager.GetAll()
data := []*ocmetricdata.Metric{}
Expand Down

0 comments on commit dffefdf

Please sign in to comment.