refactor(key-wallet): improve code quality with clippy fixes and formatting

[DCG-Claude]

Summary

This PR improves the key-wallet code quality by applying clippy recommendations and formatting fixes.

Changes

• Remove unnecessary clone() in basic_usage.rs example
• Change Into<u32> to From<KeyDerivationType> for more idiomatic Rust
• Remove unnecessary lifetime annotation on &str IntoDerivationPath impl
• Use matches\! macro instead of match for boolean checks
• Fix extend() call to not need a reference
• Apply cargo fmt to improve code formatting consistency

Impact

These changes follow Rust best practices and improve code maintainability without affecting functionality. All changes are purely stylistic/idiomatic improvements.

🤖 Generated with Claude Code

Summary by CodeRabbit

• Refactor

  • Simplified and modernized internal logic for key derivation and decoding, improving code readability without affecting functionality.
  • Updated trait implementations for type conversions to align with current best practices.
  • Streamlined error handling in account derivation methods for cleaner code.

• Style

  • Minor reordering of import statements for improved code organization.

[coderabbitai]

Walkthrough

This update refactors and simplifies code across several modules in the key-wallet project. Changes include streamlined error mapping, trait implementation updates, minor argument type adjustments, import reordering, and a modification to ownership semantics in an example. No functional behavior is altered.

Changes

File(s)	Change Summary
key-wallet/examples/basic_usage.rs	Passes account by ownership (not clone) to AccountDerivation::new, altering ownership semantics.
key-wallet/src/bip32.rs	Changes trait impls: Into<u32> → From<KeyDerivationType> for u32; simplifies hardened check logic and trait bounds.
key-wallet/src/derivation.rs	Refactors error mapping in AccountDerivation methods to a single chained line each.
key-wallet/src/dip9.rs	Changes DerivationPath::extend argument from slice reference to array (implicitly coerced).
key-wallet/tests/address_tests.rs	Moves use std::str::FromStr; import after other imports; no logic changes.

Possibly related PRs

• refactor(key-wallet): improve API with standard FromStr trait and bet… #85: Refactors AccountDerivation methods to derive private keys before public keys, modifying similar logic in key-wallet/src/derivation.rs.

Poem

In the warren of code, the rabbits convene,
To tidy the paths and keep logic clean.
Ownership passed, and errors mapped neat,
Imports now ordered, the code feels complete.
With a hop and a skip, the wallet hops on—
Simpler, sleeker, and bugs all gone!
🐇✨

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Clippy (1.86.0)

warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package: /dash-spv-ffi/Cargo.toml
workspace: /Cargo.toml
Updating git repository https://github.com/dashpay/agora-blsful
error: failed to load source for dependency blsful

Caused by:
Unable to update https://github.com/dashpay/agora-blsful?rev=5f017aa1a0452ebc73e47f219f50c906522df4ea

Caused by:
failed to create directory /usr/local/git/db/agora-blsful-002ebda36d727958

Caused by:
Permission denied (os error 13)

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 44e12a9 and f3cf722.

📒 Files selected for processing (5)

• key-wallet/examples/basic_usage.rs (1 hunks)
• key-wallet/src/bip32.rs (4 hunks)
• key-wallet/src/derivation.rs (2 hunks)
• key-wallet/src/dip9.rs (1 hunks)
• key-wallet/tests/address_tests.rs (1 hunks)

🧰 Additional context used

🧠 Learnings (6)

📓 Common learnings

Learnt from: QuantumExplorer
PR: dashpay/rust-dashcore#74
File: key-wallet/src/address.rs:30-40
Timestamp: 2025-06-15T15:31:44.136Z
Learning: In the key-wallet crate, QuantumExplorer prefers keeping wildcard arms that default unknown Network variants to testnet prefixes rather than using exhaustive matches or panics. This fallback behavior is intentional.

Learnt from: QuantumExplorer
PR: dashpay/rust-dashcore#74
File: key-wallet-ffi/src/lib_tests.rs:41-48
Timestamp: 2025-06-15T16:42:18.187Z
Learning: In key-wallet-ffi, the HDWallet::derive_xpriv method returns Result<String, KeyWalletError>, not an ExtPrivKey wrapper. When unwrapped, it yields a String that can have .is_empty() called on it.

key-wallet/tests/address_tests.rs (2)

Learnt from: QuantumExplorer
PR: dashpay/rust-dashcore#74
File: key-wallet-ffi/src/lib_tests.rs:41-48
Timestamp: 2025-06-15T16:42:18.187Z
Learning: In key-wallet-ffi, the HDWallet::derive_xpriv method returns Result<String, KeyWalletError>, not an ExtPrivKey wrapper. When unwrapped, it yields a String that can have .is_empty() called on it.

Learnt from: QuantumExplorer
PR: dashpay/rust-dashcore#74
File: key-wallet/src/address.rs:30-40
Timestamp: 2025-06-15T15:31:44.136Z
Learning: In the key-wallet crate, QuantumExplorer prefers keeping wildcard arms that default unknown Network variants to testnet prefixes rather than using exhaustive matches or panics. This fallback behavior is intentional.

key-wallet/examples/basic_usage.rs (1)

Learnt from: QuantumExplorer
PR: dashpay/rust-dashcore#74
File: key-wallet-ffi/src/lib_tests.rs:41-48
Timestamp: 2025-06-15T16:42:18.187Z
Learning: In key-wallet-ffi, the HDWallet::derive_xpriv method returns Result<String, KeyWalletError>, not an ExtPrivKey wrapper. When unwrapped, it yields a String that can have .is_empty() called on it.

key-wallet/src/derivation.rs (1)

Learnt from: QuantumExplorer
PR: dashpay/rust-dashcore#74
File: key-wallet-ffi/src/lib_tests.rs:41-48
Timestamp: 2025-06-15T16:42:18.187Z
Learning: In key-wallet-ffi, the HDWallet::derive_xpriv method returns Result<String, KeyWalletError>, not an ExtPrivKey wrapper. When unwrapped, it yields a String that can have .is_empty() called on it.

key-wallet/src/dip9.rs (1)

Learnt from: QuantumExplorer
PR: dashpay/rust-dashcore#74
File: key-wallet-ffi/src/lib_tests.rs:41-48
Timestamp: 2025-06-15T16:42:18.187Z
Learning: In key-wallet-ffi, the HDWallet::derive_xpriv method returns Result<String, KeyWalletError>, not an ExtPrivKey wrapper. When unwrapped, it yields a String that can have .is_empty() called on it.

key-wallet/src/bip32.rs (1)

Learnt from: QuantumExplorer
PR: dashpay/rust-dashcore#74
File: key-wallet-ffi/src/lib_tests.rs:41-48
Timestamp: 2025-06-15T16:42:18.187Z
Learning: In key-wallet-ffi, the HDWallet::derive_xpriv method returns Result<String, KeyWalletError>, not an ExtPrivKey wrapper. When unwrapped, it yields a String that can have .is_empty() called on it.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)

• GitHub Check: fuzz (dash_deser_net_msg)
• GitHub Check: fuzz (hashes_sha256)
• GitHub Check: fuzz (hashes_json)
• GitHub Check: fuzz (hashes_cbor)
• GitHub Check: fuzz (hashes_sha512)
• GitHub Check: fuzz (hashes_sha1)
• GitHub Check: fuzz (hashes_sha512_256)
• GitHub Check: fuzz (dash_deserialize_script)
• GitHub Check: fuzz (hashes_ripemd160)
• GitHub Check: fuzz (dash_deserialize_block)
• GitHub Check: fuzz (dash_deserialize_witness)
• GitHub Check: fuzz (dash_script_bytes_to_asm_fmt)
• GitHub Check: fuzz (dash_deserialize_address)
• GitHub Check: fuzz (dash_deserialize_amount)
• GitHub Check: fuzz (dash_outpoint_string)

🔇 Additional comments (9)

key-wallet/tests/address_tests.rs (1)

8-8: LGTM: Import reordering for consistency.

The import reordering aligns with standard Rust formatting conventions and doesn't affect functionality.

key-wallet/examples/basic_usage.rs (1)

39-39: LGTM: Removed unnecessary clone operation.

Passing ownership directly to AccountDerivation::new instead of cloning improves performance without affecting functionality.

key-wallet/src/derivation.rs (2)

161-161: LGTM: Streamlined error mapping.

Consolidating the error mapping directly onto the derive_priv call simplifies the code while maintaining the same error handling behavior.

---

170-170: LGTM: Streamlined error mapping.

Consolidating the error mapping directly onto the derive_priv call simplifies the code while maintaining the same error handling behavior.

key-wallet/src/dip9.rs (1)

78-78: LGTM: Cleaner array passing to extend method.

Passing the array directly instead of taking a reference is more idiomatic and equally functional since arrays are coerced to slices automatically.

key-wallet/src/bip32.rs (4)

777-784: LGTM: Prefer From trait over Into.

Implementing From<KeyDerivationType> for u32 is more idiomatic than Into<u32> for KeyDerivationType and automatically provides the Into implementation.

---

988-992: LGTM: Removed unnecessary lifetime annotation.

The compiler can infer the lifetime for the &str parameter, making the code cleaner without explicit annotation.

---

1446-1446: LGTM: Modernized boolean check with matches! macro.

Using !matches!(hardening_byte, 0x00) is more concise and idiomatic than a match statement for simple boolean conditions.

---

1778-1778: LGTM: Modernized boolean check with matches! macro.

Using !matches!(hardening_byte, 0x00) is more concise and idiomatic than a match statement for simple boolean conditions.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[PastaPastaPasta]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.