Fix/genesis testnet

[pankcuf]

This pull request includes several changes to the dash module, focusing on improving type consistency and simplifying code.

Type Consistency Improvements:

• dash/src/consensus/encode.rs: Added impl_vec!(i32); to support encoding of i32 type.
• dash/src/network/message_qrinfo.rs: Changed skip_list type from Vec<u32> to Vec<i32> in the QuorumSnapshot struct to align with the intended data type.

Fix:

• dash/src/network/constants.rs: Testnet genesis block hash should be reversed here.

Summary by CodeRabbit

• New Features

  • Added support for encoding and decoding vectors of 32-bit signed integers.

• Bug Fixes

  • Updated the skip list in quorum snapshots to use signed 32-bit integers, improving data representation.

• Refactor

  • Streamlined the process for constructing the Testnet genesis block hash for improved efficiency.

• Chores

  • Updated the workspace package version to 0.39.6.

[coderabbitai]

Walkthrough

This update includes several focused changes. The workspace package version in Cargo.toml is incremented from "0.39.4" to "0.39.6". In the consensus encoding module, support for encoding and decoding Vec<i32> is added. The QuorumSnapshot struct's skip_list field changes its type from Vec<u32> to Vec<i32>. Additionally, the construction of the Testnet genesis block hash is streamlined by eliminating redundant hex decoding operations.

Changes

File(s)	Change Summary
Cargo.toml	Updated workspace package version from "0.39.4" to "0.39.6".
dash/src/consensus/encode.rs	Added impl_vec!(i32); to implement encoding/decoding for Vec<i32>.
dash/src/network/constants.rs	Simplified Testnet genesis block hash construction by removing redundant hex decoding.
dash/src/network/message_qrinfo.rs	Changed QuorumSnapshot.skip_list field type from Vec<u32> to Vec<i32>.

Poem

A hop and a skip, a version anew,
Now vectors of i32 can hop along too!
Genesis hash, less tangled, more neat,
And skip lists now sign what once was discrete.
With every small change, our code leaps ahead—
A rabbit’s delight in the progress we’ve bred!
🐇✨

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

dash/src/network/message_qrinfo.rs (1)

160-160: Update the type in the comment to match the code.

The type was correctly changed from Vec<u32> to Vec<i32>, but the comment still says "Array of uint32_t". Please update the comment to accurately reflect the new type.

-    pub skip_list: Vec<i32>,              // Array of uint32_t
+    pub skip_list: Vec<i32>,              // Array of int32_t

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8a87e75 and ecd9960.

📒 Files selected for processing (4)

• Cargo.toml (1 hunks)
• dash/src/consensus/encode.rs (1 hunks)
• dash/src/network/constants.rs (1 hunks)
• dash/src/network/message_qrinfo.rs (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

dash/src/network/constants.rs (3)

hashes/src/sha256.rs (1)

• from_byte_array (162-164)

hashes/src/lib.rs (1)

• from_byte_array (226-226)

dash/src/blockdata/block.rs (2)

• block_hash (60-64)
• block_hash (214-216)

⏰ Context from checks skipped due to timeout of 90000ms (10)

• GitHub Check: fuzz (dash_deser_net_msg)
• GitHub Check: fuzz (dash_deserialize_amount)
• GitHub Check: fuzz (hashes_sha512)
• GitHub Check: fuzz (hashes_ripemd160)
• GitHub Check: fuzz (hashes_sha256)
• GitHub Check: fuzz (hashes_cbor)
• GitHub Check: fuzz (dash_deserialize_address)
• GitHub Check: fuzz (hashes_sha512_256)
• GitHub Check: fuzz (dash_deserialize_witness)
• GitHub Check: fuzz (dash_outpoint_string)

🔇 Additional comments (3)

Cargo.toml (1)

6-6: Version increment looks good.

The version bump from 0.39.4 to 0.39.6 corresponds with the functionality changes in this PR.

dash/src/consensus/encode.rs (1)

741-741: Good addition of impl_vec!(i32) for type consistency.

This change adds support for encoding and decoding Vec<i32> types, which is necessary to support the change in QuorumSnapshot::skip_list from Vec<u32> to Vec<i32>.

dash/src/network/constants.rs (1)

166-166: Clean implementation of the testnet genesis block hash.

This change simplifies the construction of the testnet genesis block hash by removing redundant steps, making the code more consistent with the mainnet implementation above.