fix: fix bincode import and pass None to apply diff when validation is false

[QuantumExplorer]

We imported bincode incorrectly and forgot to pass None to a function when validation was set to false.

Summary by CodeRabbit

• Chores
  • Updated the package version to v0.39.3.
• Refactor
  • Improved flexibility by enabling conditional data processing.
  • Enhanced verification routines through expanded optional inputs.

These improvements help streamline operations and contribute to a more robust and flexible system.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request updates the package version in the workspace, modifies the U256 struct in the power module to conditionally derive serialization traits based on the "bincode" feature, and extends the apply_diff method of the masternode list engine to accept an additional optional parameter for previous chain lock signatures.

Changes

File(s)	Change Summary
Cargo.toml	Updated [workspace.package] version from "0.39.2" to "0.39.3".
dash/src/pow.rs	Changed U256 struct derivation by removing direct Encode, Decode traits and adding conditional derivation with #[cfg_attr(feature="bincode", derive(Encode, Decode))].
dash/src/sml/masternode_list_engine/mod.rs	Modified apply_diff method signature to include a new optional parameter (previous_chain_lock_sigs: Option<[BLSSignature; 3]>).

Sequence Diagram(s)

sequenceDiagram
    participant C as Client
    participant M as MasternodeListEngine
    participant B as BaseMasternodeList

    C->>M: apply_diff(diff, diff_end_height, verify_quorums, previous_chain_lock_sigs)
    M->>B: apply_diff(diff, diff_end_height, verify_quorums, previous_chain_lock_sigs)
    B-->>M: Return BLSSignature/Result or error
    M-->>C: Return result

Loading

Poem

I'm a hopping rabbit with a coder's delight,
Scurrying through versions in the pale moonlight.
Conditional traits now bloom with a feature so keen,
And extra parameters make our function sheen.
I celebrate these changes with a joyful hop and a bright, merry beam!

Tip

⚡💬 Agentic Chat (Pro Plan, General Availability)

• We're introducing multi-step agentic chat in review comments and issue comments, within and outside of PR's. This feature enhances review and issue discussions with the CodeRabbit agentic chat by enabling advanced interactions, including the ability to create pull requests directly from comments and add commits to existing pull requests.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 05ca90e and e9dbc89.

📒 Files selected for processing (3)

• Cargo.toml (1 hunks)
• dash/src/pow.rs (2 hunks)
• dash/src/sml/masternode_list_engine/mod.rs (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai plan to trigger planning for file edits and PR creation.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.