removed fork detector and fork structs #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…after las removal
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
xdustinface
approved these changes
Dec 19, 2025
xdustinface
pushed a commit
that referenced
this pull request
Dec 21, 2025
* removed chain storage an related code * chore: removed fork detector and fork structs (#290)
xdustinface
pushed a commit
that referenced
this pull request
Dec 22, 2025
* removed chain storage an related code * chore: removed fork detector and fork structs (#290) * removed filters field from ChainState (ez)
xdustinface
pushed a commit
that referenced
this pull request
Jan 3, 2026
* removed chain storage an related code * removed headers from ChainState * tip_height method removed * removed get_tip_hesh * replaced header_at_height * removed unused methods * init_from_checkpoint sync * tip_header removed * removed two methos that where invovled in the same process * fixed ffi * test updated to the changes * chore: removed fork detector and fork structs (#290) * get_header now checks out of bound to return None instead of panics * start height was not being updated properly * fixed other test by correctly storing the headers in the storage * removed genesis block creation in ChainState creation * fixed clippy warnings * dropped unuseed code * code review suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After removing ChainStorage I found out that ForkDetector was not being used and that lead to For not being used either. The reorg module was not being used either