Skip to content

Conversation

@pauldelucia
Copy link
Member

DAPI returns quorum hash in big endian in its ResponseMetadata that comes with query and state transition proofs, and in SPV we store quorum hashes in little endian. So if we want a client like DET to simply take the hash from DAPI and pass it to SPV, we need to reverse it before lookup.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 27, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/reverse-hash

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@xdustinface xdustinface force-pushed the feat/dash-spv-client-interface branch from 2340750 to c586be9 Compare November 27, 2025 10:12
Copy link
Collaborator

@xdustinface xdustinface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems more like a client specific thing. Shouldn't this be done in DET rather since SPV follows and matches core?

@pauldelucia pauldelucia force-pushed the fix/reverse-hash branch 2 times, most recently from 994f45d to 1d765dd Compare December 3, 2025 10:57
@pauldelucia pauldelucia changed the title fix(spv): reverse quorum hash before lookup feat(spv): reverse quorum hash lookup function Dec 3, 2025
@xdustinface xdustinface changed the base branch from feat/dash-spv-client-interface to v0.41-dev December 3, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants