Skip to content

Conversation

@QuantumExplorer
Copy link
Member

@QuantumExplorer QuantumExplorer commented Sep 28, 2025

One integration test NEVER worked, it's best we disable it until it is recreated for Dash.

Summary by CodeRabbit

  • New Features
    • No user-facing feature changes in this release.
  • Chores
    • Disabled the Integration Tests job in the CI pipeline, preventing those tests from running in automated builds. All other automation remains unchanged.
  • Style
    • Minor formatting cleanup in the CI workflow configuration.
  • Tests
    • No changes to test logic or coverage; only execution of the disabled integration test job is affected.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 28, 2025

Walkthrough

Integration Tests job in .github/workflows/rust.yml is conditionally disabled by adding if: ${{ false }}, causing the job to be skipped without removal. Minor formatting cleanup (trailing blank line removed). No other logic or behavior changes.

Changes

Cohort / File(s) Summary of Changes
CI Workflow Updates
.github/workflows/rust.yml
Added conditional if: ${{ false }} to the Integration Tests job to disable it; removed trailing blank line. No other changes to steps or logic.

Sequence Diagram(s)

sequenceDiagram
    participant Dev as Developer
    participant GH as GitHub Actions
    participant Job as Integration Tests Job
    participant R as Runner

    Dev->>GH: Push/PR triggers workflow
    GH->>Job: Evaluate job condition
    Note right of Job: Condition: if: ${{ false }}
    alt Condition false
        Job-->>GH: Mark as skipped
        GH-->>Dev: Report job skipped
    else Condition true
        GH->>R: Schedule job steps
        R-->>GH: Run tests and report
    end
Loading

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

I twitch my whiskers, press pause on the run,
The tests take a nap, their sprint undone.
A carrot-shaped toggle: false for today,
Pipelines yawn, then scurry away.
When moons align, we’ll hop back in—
Green meadows await our CI win! 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The pull request title "ci: temp disable integration tests" clearly and succinctly conveys the main change of temporarily disabling the integration tests in the CI configuration, directly reflecting the modifications made without unnecessary detail.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ci/tempDisableIntegration

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 159712e and 4f4590d.

📒 Files selected for processing (1)
  • .github/workflows/rust.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (14)
  • GitHub Check: fuzz (hashes_sha512_256)
  • GitHub Check: fuzz (hashes_ripemd160)
  • GitHub Check: fuzz (dash_deserialize_amount)
  • GitHub Check: fuzz (dash_deserialize_block)
  • GitHub Check: fuzz (dash_deserialize_address)
  • GitHub Check: fuzz (hashes_json)
  • GitHub Check: fuzz (dash_script_bytes_to_asm_fmt)
  • GitHub Check: fuzz (dash_deserialize_witness)
  • GitHub Check: fuzz (dash_deserialize_script)
  • GitHub Check: fuzz (dash_deser_net_msg)
  • GitHub Check: RPC Tests (stable, true)
  • GitHub Check: Strict Warnings and Clippy Checks
  • GitHub Check: Core Components Tests
  • GitHub Check: SPV Components Tests
🔇 Additional comments (1)
.github/workflows/rust.yml (1)

332-332: Ensure we have a follow-up plan to re-enable this job.

Setting if: ${{ false }} skips the entire Integration Tests job, so those checks will stop running until we flip it back. Please confirm there’s a ticket or dated plan to re-enable it so we don’t lose coverage indefinitely.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@QuantumExplorer QuantumExplorer merged commit 487e553 into v0.40-dev Sep 28, 2025
25 of 26 checks passed
@QuantumExplorer QuantumExplorer deleted the ci/tempDisableIntegration branch September 28, 2025 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants