test: update bip158 test data from dash core and enable test

[PastaPastaPasta]

Summary by CodeRabbit

• Tests
  • Enabled previously skipped block filter test.
  • Refreshed block filter test vectors with Dash-specific data, including updated genesis and multiple historical blocks.
  • Added richer scenarios (witness data, multisig patterns, empty scripts, large transactions, unparseable outputs) to expand coverage.
  • Updated references to use Dash test data source.
  • Improves reliability and breadth of block filter validation.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Unignored a previously skipped test in dash/src/bip158.rs and updated its comment to reference Dash test data. Rewrote and expanded dash/tests/data/blockfilters.json with new/updated block entries, hashes, filters, headers, and prev-output scripts, including richer cases (witness data, empty scripts, complex transactions).

Changes

Cohort / File(s)	Summary
Test activation dash/src/bip158.rs	Removed #[ignore] from test_blockfilters; updated comment URL to Dash-specific test data source.
Block filter test dataset overhaul dash/tests/data/blockfilters.json	Replaced and added multiple block entries (e.g., heights 0, 2, 3, 49291, 180480, 926485, 987876, 1263442, 1414221) with updated block hashes, previous headers, basic filters, and extensive prev-output scripts, including cases with witness data and special parsing notes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

• ogabrielides
• QuantumExplorer

Poem

A hop and a skip through filters we go,
New hashes gleam where old ones used to glow.
I twitch my whiskers—tests now run!
Scripts and witnesses, oh what fun!
From genesis to peaks we tread—
Carrots compiled, all green ahead. 🥕✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 0b53a19 and acaa9fd.

📒 Files selected for processing (2)

• dash/src/bip158.rs (1 hunks)
• dash/tests/data/blockfilters.json (1 hunks)

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch test/fix-bip158

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.